Messages in this thread | | | Date | Sun, 14 Jan 2018 21:47:28 +0100 (CET) | From | Thomas Gleixner <> | Subject | Re: [PATCH V4 2/8] perf/x86/intel/uncore: correct fixed counter index check for NHM |
| |
On Thu, 2 Nov 2017, kan.liang@intel.com wrote:
> From: Kan Liang <Kan.liang@intel.com> > > For Nehalem and Westmere, there is only one fixed counter for W-Box. > There is no index which is bigger than UNCORE_PMC_IDX_FIXED. > It is not correct to use >= to check fixed counter. > The code quality issue will bring problem when new counter index is > introduced. > > Signed-off-by: Kan Liang <Kan.liang@intel.com>
Reviewed-by: Thomas Gleixner <tglx@linutronix.de>
| |