Messages in this thread | | | Date | Sun, 14 Jan 2018 01:22:05 +0530 | From | Himanshu Jha <> | Subject | Re: [Cocci] [PATCH] Coccinelle: kzalloc-simple: Rename kzalloc-simple to zalloc-simple |
| |
On Sat, Jan 13, 2018 at 05:13:36PM -0200, Fabio Estevam wrote: > On Sat, Jan 13, 2018 at 3:53 PM, Himanshu Jha > <himanshujha199640@gmail.com> wrote: > > > Yes, I used 'git mv'. > > > > It doesn't matter when applying through 'git am', both will result the > > same AFAIK and only difference is that the patch files generated by 'git > > format-patch' are different. But that is not important I think. > > You missed the -M option when running 'git format'. > > For reviewers it is not that easy to realize that the 448 lines of the > original file are the same as the ones in the new file. > > The -M option generates a much cleaner patch.
I guess you're right because patch has many lines. No problem, I will send again with a much cleaner patch. :-)
-- Thanks Himanshu Jha
| |