Messages in this thread | | | From | Mathieu Poirier <> | Subject | [PATCH 0/1] perf util: Do not reuse target->per_thread flag | Date | Fri, 12 Jan 2018 16:12:22 -0700 |
| |
Hi Arnaldo,
Here is another stab at addressing the side effect introduced by commit ("73c0ca1eee3d perf thread_map: Enumerate all threads from /proc").
I have decided to add another variable to struct target, which keep things simple and doesn't touch the core. Another solution could have been to make target->per_thread an enumaration with values PER_THREAD and ALL_THREAD, something that could be switched on in function thread_map__new_str().
I opted for the first option as it makes the code easier to understand. Let me know what you prefer or get back to me with a better solution if you see one.
Thanks, Mathieu
Mathieu Poirier (1): perf util: Do not reuse target->per_thread flag
tools/perf/builtin-stat.c | 2 +- tools/perf/util/evlist.c | 2 +- tools/perf/util/target.h | 1 + tools/perf/util/thread_map.c | 4 ++-- tools/perf/util/thread_map.h | 2 +- 5 files changed, 6 insertions(+), 5 deletions(-)
-- 2.7.4
| |