lkml.org 
[lkml]   [2018]   [Jan]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] target-core: don't use "const char*" for a buffer that is written to
From
Date
Hi Rasmus,

Apologies for the delayed follow-up on this.

On Tue, 2017-11-21 at 01:12 +0100, Rasmus Villemoes wrote:
> From: Rasmus Villemoes <rasmus.villemoes@prevas.dk>
>
> iscsi_parse_pr_out_transport_id launders the const away via a call to
> strstr(), and then modifies the buffer (writing a nul byte) through
> the return value. It's cleaner to be honest and simply declare the
> parameter as "char*", fixing up the call chain, and allowing us to
> drop the cast in the return statement.
>
> Amusingly, the two current callers found it necessary to cast a
> non-const pointer to a const.
>
> Signed-off-by: Rasmus Villemoes <linux@rasmusvillemoes.dk>
> ---
> drivers/target/target_core_fabric_lib.c | 6 +++---
> drivers/target/target_core_internal.h | 2 +-
> drivers/target/target_core_pr.c | 4 ++--
> 3 files changed, 6 insertions(+), 6 deletions(-)
>

Looks fine. Applied.

Thank you.


\
 
 \ /
  Last update: 2018-01-14 23:26    [W:0.029 / U:0.112 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site