lkml.org 
[lkml]   [2018]   [Jan]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v3] ftrace/module: Move ftrace_release_mod() to ddebug_cleanup label
On Fri, 12 Jan 2018 18:32:27 +0100
Jessica Yu <jeyu@kernel.org> wrote:

> +++ Namit Gupta [08/01/18 10:41 +0530]:
> >ftrace_module_init happen after dynamic_debug_setup, it is desired that
> >cleanup should be called after this label however in current implementation
> >it is called in free module label,ie:even though ftrace in not initialized,
> >from so many fail case ftrace_release_mod() will be called and unnecessary
> >traverse the whole list.
> >In below patch we moved ftrace_release_mod() from free_module label to
> >ddebug_cleanup label. that is the best possible location, other solution
> >is to make new label to ftrace_release_mod() but since ftrace_module_init()
> >is not return with minimum changes it should be in ddebug_cleanup label.
> >
> >Signed-off-by: Namit Gupta <gupta.namit@samsung.com>
>
> Hi Steven,
>
> Could I get an ACK for this patch?
>

Hi Jessica,

Thanks for asking, because this came in while I was traveling and is
buried in the "travel log" part of my inbox.

Please add:

Reviewed-by: Steven Rostedt (VMware) <rostedt@goodmis.org>

-- Steve

\
 
 \ /
  Last update: 2018-01-14 23:26    [W:0.052 / U:0.056 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site