Messages in this thread | | | Subject | Re: [PATCH] null_blk: remove explicit 'select FAULT_INJECTION' | From | Jens Axboe <> | Date | Thu, 11 Jan 2018 07:57:53 -0700 |
| |
On 1/11/18 3:31 AM, Arnd Bergmann wrote: > Selecting FAULT_INJECTION causes a Kconfig warning when CONFIG_DEBUG_KERNEL > is not set: > > warning: (BLK_DEV_NULL_BLK && DRM_I915_SELFTEST) selects FAULT_INJECTION which has unmet direct dependencies (DEBUG_KERNEL) > > The other drivers that use FAULT_INJECTION tend to have a separate > Kconfig symbol for turning on that feature, so let's do the same > thing here. This may add a bit more complexity than we like, but > it avoids the warning and is more consistent with the rest of the > kernel.
Thanks Arnd, I'll get this applied.
> diff --git a/drivers/block/Kconfig b/drivers/block/Kconfig > index 622d9a2c8dae..b795d0ca74eb 100644 > --- a/drivers/block/Kconfig > +++ b/drivers/block/Kconfig > @@ -19,7 +19,10 @@ if BLK_DEV > config BLK_DEV_NULL_BLK > tristate "Null test block driver" > select CONFIGFS_FS > - select FAULT_INJECTION > + > +config BLK_DEV_NULL_BLK_FAULT_INJECTION > + bool "Support fault injection for Nll test block driver" > + depends on BLK_DEV_NULL_BLK && FAULT_INJECTION
Will fixup that typo.
-- Jens Axboe
| |