lkml.org 
[lkml]   [2018]   [Jan]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] null_blk: remove explicit 'select FAULT_INJECTION'
From
Date
On 1/11/18 3:31 AM, Arnd Bergmann wrote:
> Selecting FAULT_INJECTION causes a Kconfig warning when CONFIG_DEBUG_KERNEL
> is not set:
>
> warning: (BLK_DEV_NULL_BLK && DRM_I915_SELFTEST) selects FAULT_INJECTION which has unmet direct dependencies (DEBUG_KERNEL)
>
> The other drivers that use FAULT_INJECTION tend to have a separate
> Kconfig symbol for turning on that feature, so let's do the same
> thing here. This may add a bit more complexity than we like, but
> it avoids the warning and is more consistent with the rest of the
> kernel.

Thanks Arnd, I'll get this applied.

> diff --git a/drivers/block/Kconfig b/drivers/block/Kconfig
> index 622d9a2c8dae..b795d0ca74eb 100644
> --- a/drivers/block/Kconfig
> +++ b/drivers/block/Kconfig
> @@ -19,7 +19,10 @@ if BLK_DEV
> config BLK_DEV_NULL_BLK
> tristate "Null test block driver"
> select CONFIGFS_FS
> - select FAULT_INJECTION
> +
> +config BLK_DEV_NULL_BLK_FAULT_INJECTION
> + bool "Support fault injection for Nll test block driver"
> + depends on BLK_DEV_NULL_BLK && FAULT_INJECTION

Will fixup that typo.

--
Jens Axboe

\
 
 \ /
  Last update: 2018-01-14 23:23    [W:0.044 / U:0.636 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site