lkml.org 
[lkml]   [2018]   [Jan]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] perf evsel: Fix incorrect handling of type _TERM_DRV_CFG
On Wed, Jan 10, 2018 at 01:46:51PM -0700, Mathieu Poirier wrote:
> Commit ("d0565132605f perf evsel: Enable type checking for
> perf_evsel_config_term types") assumes PERF_EVSEL__CONFIG_TERM_DRV_CFG
> isn't used and as such adds a BUG_ON().
>
> Since the enumeration type is used in macro ADD_CONFIG_TERM() the change
> break CoreSight trace acquisition.
>
> This patch restores the original code.
>
> Signed-off-by: Mathieu Poirier <mathieu.poirier@linaro.org>

Acked-by: Jiri Olsa <jolsa@kernel.org>

thanks,
jirka

> ---
> tools/perf/util/evsel.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/perf/util/evsel.c b/tools/perf/util/evsel.c
> index a4d256ea0dc4..b22071a20cd1 100644
> --- a/tools/perf/util/evsel.c
> +++ b/tools/perf/util/evsel.c
> @@ -781,7 +781,7 @@ static void apply_config_terms(struct perf_evsel *evsel,
> attr->write_backward = term->val.overwrite ? 1 : 0;
> break;
> case PERF_EVSEL__CONFIG_TERM_DRV_CFG:
> - BUG_ON(1);
> + break;
> default:
> break;
> }
> --
> 2.7.4
>

\
 
 \ /
  Last update: 2018-01-14 23:23    [W:0.073 / U:0.700 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site