Messages in this thread | | | Subject | Re: [f2fs-dev] [PATCH] f2fs: prevent newly created inode from being dirtied incorrectly | From | Chao Yu <> | Date | Thu, 11 Jan 2018 17:52:38 +0800 |
| |
On 2018/1/11 10:26, Daeho Jeong wrote: > Now, we invoke f2fs_mark_inode_dirty_sync() to make an inode dirty in > advance of creating a new node page for the inode. By this, some inodes > whose node page is not created yet can be linked into the global dirty > list. > > If the checkpoint is executed at this moment, the inode will be written > back by writeback_single_inode() and finally update_inode_page() will > fail to detach the inode from the global dirty list because the inode > doesn't have a node page. > > The problem is that the inode's state in VFS layer will become clean > after execution of writeback_single_inode() and it's still linked in > the global dirty list of f2fs and this will cause a kernel panic. > > So, we will prevent the newly created inode from being dirtied during > the FI_NEW_INODE flag of the inode is set. We will make it dirty > right after the flag is cleared. > > Signed-off-by: Daeho Jeong <daeho.jeong@samsung.com> > Signed-off-by: Youngjin Gil <youngjin.gil@samsung.com> > Tested-by: Hobin Woo <hobin.woo@samsung.com>
Reviewed-by: Chao Yu <yuchao0@huawei.com>
Thanks,
| |