Messages in this thread | | | From | Felipe Balbi <> | Subject | Re: [PATCH] usb: dwc3: core: Don't try to get PHYs during suspend/resume | Date | Thu, 11 Jan 2018 10:25:35 +0200 |
| |
Hi,
Roger Quadros <rogerq@ti.com> writes: >>>> - ret = dwc3_core_soft_reset(dwc); >>>> + ret = dwc3_core_get_phy(dwc); >>> >>> we can get_phy in dwc3_core_init() as it will get called on resume(). >>> This was the $subject of this patch. >> >> indeed. thanks :-) >> > > oops sorry. I meant we can't call dwc3_core_get_phy() in dwc3_core_init(). :P
bit of a chicken-and-egg problem. We need to setup the PHY interface before getting the PHYs, but can't get PHY during resume. Maybe the best way here would be to check for the pointers being valid. Something like:
if (!phy) get_phy();
-- balbi [unhandled content-type:application/pgp-signature]
| |