lkml.org 
[lkml]   [2018]   [Jan]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
SubjectRe: [PATCH] leds: ledtrig-transient: Add SPDX license identifiers
From
Date
Hi Shuah,

Thanks for the patch.

On 01/10/2018 05:35 PM, Shuah Khan wrote:
> Replace GPL license statements with SPDX GPL-2.0 license identifiers
> and and correct the module license to GPLv2.
>
> Signed-off-by: Shuah Khan <shuahkh@osg.samsung.com>
> ---
> drivers/leds/trigger/ledtrig-transient.c | 7 ++-----
> 1 file changed, 2 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/leds/trigger/ledtrig-transient.c b/drivers/leds/trigger/ledtrig-transient.c
> index 7acce64b692a..f0578af858e7 100644
> --- a/drivers/leds/trigger/ledtrig-transient.c
> +++ b/drivers/leds/trigger/ledtrig-transient.c
> @@ -1,3 +1,4 @@
> +/* SPDX-License-Identifier: GPL-2.0 */
> /*

How about changing this whole block comment to "//"?
We did it already for drivers/leds/trigger/ledtrig-netdev.c,
present in linux-next. See related discussion with reference
to relevant Linus' guidelines in this matter [0].

> * LED Kernel Transient Trigger
> *
> @@ -8,10 +9,6 @@
> * Design and use-case input from Jonas Bonn <jonas@southpole.se> and
> * Neil Brown <neilb@suse.de>
> *
> - * This program is free software; you can redistribute it and/or modify
> - * it under the terms of the GNU General Public License version 2 as
> - * published by the Free Software Foundation.
> - *
> */
> /*
> * Transient trigger allows one shot timer activation. Please refer to
> @@ -238,4 +235,4 @@ module_exit(transient_trig_exit);
>
> MODULE_AUTHOR("Shuah Khan <shuahkhan@gmail.com>");
> MODULE_DESCRIPTION("Transient LED trigger");
> -MODULE_LICENSE("GPL");
> +MODULE_LICENSE("GPL v2");
>

[0] https://www.mail-archive.com/netdev@vger.kernel.org/msg204598.html

--
Best regards,
Jacek Anaszewski
\
 
 \ /
  Last update: 2018-01-14 23:22    [W:0.098 / U:0.680 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site