lkml.org 
[lkml]   [2018]   [Jan]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] uio_hv_generic: fix type mismatch warnings
On Wed, 10 Jan 2018 17:42:38 +0100
Arnd Bergmann <arnd@arndb.de> wrote:

> I moved the virt_to_phys() conversion into hv_uio_probe() as part of
> a warning fix. Stephen's cleanup to remove the private mmap() function
> seems reasonable, but part of it reverted the change that I did to
> hide the warnings, so they are back now:
>
> drivers/uio/uio_hv_generic.c: In function 'hv_uio_probe':
> drivers/uio/uio_hv_generic.c:123:5: error: cast from pointer to integer of different size [-Werror=pointer-to-int-cast]
> drivers/uio/uio_hv_generic.c:130:5: error: cast from pointer to integer of different size [-Werror=pointer-to-int-cast]
> drivers/uio/uio_hv_generic.c:136:5: error: cast from pointer to integer of different size [-Werror=pointer-to-int-cast]
>
> The type mismatch is now the result of the uio_mmap() definition, and
> the best way I see from here is to shut them up with a uintptr_t cast.
>
> Fixes: 9c40546c012c ("uio_hv_generic: use standard mmap for resources")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>

Thanks. Not sure why I don't see these.

Signed-off-by: Stephen Hemminger <sthemmin@microsoft.com>

\
 
 \ /
  Last update: 2018-01-14 23:21    [W:0.092 / U:0.188 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site