Messages in this thread Patch in this message | | | From | Jin Yao <> | Subject | [PATCH v1 3/8] perf util: Improve error checking for time percent input | Date | Wed, 10 Jan 2018 23:00:28 +0800 |
| |
The command line like 'perf report --stdio --time 1abc%/1' could be accepted by perf. It looks not very good.
This patch uses strtod() to replace original atof() and check the entire string. Now for the same command line, it would return error message "Invalid time string".
root@skl:/tmp# perf report --stdio --time 1abc%/1 Invalid time string
Signed-off-by: Jin Yao <yao.jin@linux.intel.com> --- tools/perf/util/time-utils.c | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-)
diff --git a/tools/perf/util/time-utils.c b/tools/perf/util/time-utils.c index 3f7f18f..88510ab 100644 --- a/tools/perf/util/time-utils.c +++ b/tools/perf/util/time-utils.c @@ -116,7 +116,8 @@ int perf_time__parse_str(struct perf_time_interval *ptime, const char *ostr) static int parse_percent(double *pcnt, char *str) { - char *c; + char *c, *endptr; + double d; c = strchr(str, '%'); if (c) @@ -124,8 +125,11 @@ static int parse_percent(double *pcnt, char *str) else return -1; - *pcnt = atof(str) / 100.0; + d = strtod(str, &endptr); + if (endptr != str + strlen(str)) + return -1; + *pcnt = d / 100.0; return 0; } -- 2.7.4
| |