lkml.org 
[lkml]   [2018]   [Jan]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH 1/3] ARM: dts: enable L2 cache parity and ecc on db-xc3-24g4xg board
Date
Hi Chris,

On mar., janv. 09 2018, Chris Packham <chris.packham@alliedtelesis.co.nz> wrote:

Could you have add a (even small) message in the commit log?

Also could you improve the title by specify that it applies on
armada-xp, like this:

ARM: dts: armada-xp: enable L2 cache parity and ecc on db-xc3-24g4xg


> Signed-off-by: Chris Packham <chris.packham@alliedtelesis.co.nz>
> ---
> arch/arm/boot/dts/armada-xp-db-xc3-24g4xg.dts | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/arch/arm/boot/dts/armada-xp-db-xc3-24g4xg.dts b/arch/arm/boot/dts/armada-xp-db-xc3-24g4xg.dts
> index 06fce35d7491..00ca489fc788 100644
> --- a/arch/arm/boot/dts/armada-xp-db-xc3-24g4xg.dts
> +++ b/arch/arm/boot/dts/armada-xp-db-xc3-24g4xg.dts
> @@ -70,6 +70,11 @@
> };
> };
>
> +&L2 {
> + arm,parity-enable;
> + marvell,ecc-enable;

It is not a problem for me to already applied the device tree change
even if the driver is not merged yet. But I would like to have an
acked-by on this new property by either a device tree maintainer or at
least the EDAC maintainer, of course having both acked-by would be
perfect ! :)

Thanks,

Gregory




> +};
> +
> &devbus_bootcs {
> status = "okay";
>
> --
> 2.15.1
>

--
Gregory Clement, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com

\
 
 \ /
  Last update: 2018-01-14 23:20    [W:0.074 / U:0.584 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site