Messages in this thread | | | Subject | Re: 答复: [PATCH] ION: Sys heap: fix the incorrect pool->gfp mask setting | From | Laura Abbott <> | Date | Wed, 10 Jan 2018 16:00:51 -0800 |
| |
On 01/09/2018 04:06 AM, Zengtao (B) wrote: >> -----邮件原件----- >> 发件人: Dan Carpenter [mailto:dan.carpenter@oracle.com] >> 发送时间: 2018年1月9日 17:14 >> 收件人: Chenfeng (puck) <puck.chen@hisilicon.com> >> 抄送: Zengtao (B) <prime.zeng@hisilicon.com>; labbott@redhat.com; >> sumit.semwal@linaro.org; gregkh@linuxfoundation.org; arve@android.com; >> tkjos@android.com; maco@android.com; devel@driverdev.osuosl.org; >> linux-kernel@vger.kernel.org >> 主题: Re: [PATCH] ION: Sys_heap: fix the incorrect pool->gfp_mask setting >> >> On Tue, Jan 09, 2018 at 11:30:09AM +0800, Chen Feng wrote: >>> >>> >>> On 2018/1/9 18:43, Zeng Tao wrote: >>>> This issue is introduced by the commit <e7f63771b60e> ("ION: Sys_heap: >>>> Add cached pool to spead up cached buffer alloc"), >> >> Use the Fixes tag. >> >> Fixes: e7f63771b60e ("ION: Sys_heap: Add cached pool to spead up cached >> buffer alloc") >> > Agree, thanks. >
If you're going to be fixing this, it would be good to fix the other problems pointed out (stop with the #define of the flags).
Thanks, Laura
| |