Messages in this thread | | | From | Philippe Ombredanne <> | Date | Mon, 1 Jan 2018 14:53:08 +0100 | Subject | Re: [PATCH 01/26] staging: ccree: SPDXify driver |
| |
Gilad,
On Mon, Jan 1, 2018 at 1:06 PM, Gilad Ben-Yossef <gilad@benyossef.com> wrote: > Replace verbatim GPL v2 copy with SPDX tag. > > Signed-off-by: Gilad Ben-Yossef <gilad@benyossef.com>
<snip>
> --- a/drivers/staging/ccree/cc_crypto_ctx.h > +++ b/drivers/staging/ccree/cc_crypto_ctx.h > @@ -1,18 +1,5 @@ > -/* > - * Copyright (C) 2012-2017 ARM Limited or its affiliates. > - * > - * This program is free software; you can redistribute it and/or modify > - * it under the terms of the GNU General Public License version 2 as > - * published by the Free Software Foundation. > - * > - * This program is distributed in the hope that it will be useful, > - * but WITHOUT ANY WARRANTY; without even the implied warranty of > - * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the > - * GNU General Public License for more details. > - * > - * You should have received a copy of the GNU General Public License > - * along with this program; if not, see <http://www.gnu.org/licenses/>. > - */ > +// SPDX-License-Identifier: GPL-2.0 > +// Copyright (C) 2012-2017 ARM Limited or its affiliates. >
For a .h file the style should be C comments as explained in Thomas doc patches. .e.g.
> +/* SPDX-License-Identifier: GPL-2.0 */
And then it might makes sense there too:
> +/* Copyright (C) 2012-2017 ARM Limited or its affiliates. */
-- Cordially Philippe Ombredanne
| |