lkml.org 
[lkml]   [2018]   [Jan]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 4/4] extcon: axp288: Handle reserved charger-type values better
    Hi Hans,

    On 2017년 12월 22일 21:36, Hans de Goede wrote:
    > According to the data sheets all the values not handled in the
    > switch-case are "reserved". Update the dev_warn message to reflect
    > this and set the cable-type to EXTCON_CHG_USB_SDP (so max 500mA
    > current draw) as safe default.
    >
    > Signed-off-by: Hans de Goede <hdegoede@redhat.com>
    > ---
    > drivers/extcon/extcon-axp288.c | 4 ++--
    > 1 file changed, 2 insertions(+), 2 deletions(-)
    >
    > diff --git a/drivers/extcon/extcon-axp288.c b/drivers/extcon/extcon-axp288.c
    > index cc7c35c7ff02..d60c615f709f 100644
    > --- a/drivers/extcon/extcon-axp288.c
    > +++ b/drivers/extcon/extcon-axp288.c
    > @@ -205,8 +205,8 @@ static int axp288_handle_chrg_det_event(struct axp288_extcon_info *info)
    > cable = EXTCON_CHG_USB_DCP;
    > break;
    > default:
    > - dev_warn(info->dev,
    > - "disconnect or unknown or ID event\n");
    > + dev_warn(info->dev, "unknown (reserved) bc detect result\n");
    > + cable = EXTCON_CHG_USB_SDP;
    > }
    >
    > no_vbus:
    >

    Looks good to me.
    Reviewed-by: Chanwoo Choi <cw00.choi@samsung.com>

    --
    Best Regards,
    Chanwoo Choi
    Samsung Electronics

    \
     
     \ /
      Last update: 2018-01-02 01:55    [W:4.489 / U:0.124 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site