lkml.org 
[lkml]   [2018]   [Jan]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.14 054/146] ALSA: hda - Fix missing COEF init for ALC225/295/299
    Date
    4.14-stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Takashi Iwai <tiwai@suse.de>

    commit 44be77c590f381bc629815ac789b8b15ecc4ddcf upstream.

    There was a long-standing problem on HP Spectre X360 with Kabylake
    where it lacks of the front speaker output in some situations. Also
    there are other products showing the similar behavior. The culprit
    seems to be the missing COEF setup on ALC codecs, ALC225/295/299,
    which are all compatible.

    This patch adds the proper COEF setup (to initialize idx 0x67 / bits
    0x3000) for addressing the issue.

    Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=195457
    Signed-off-by: Takashi Iwai <tiwai@suse.de>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

    ---
    sound/pci/hda/patch_realtek.c | 8 +++++---
    1 file changed, 5 insertions(+), 3 deletions(-)

    --- a/sound/pci/hda/patch_realtek.c
    +++ b/sound/pci/hda/patch_realtek.c
    @@ -324,8 +324,12 @@ static void alc_fill_eapd_coef(struct hd
    case 0x10ec0292:
    alc_update_coef_idx(codec, 0x4, 1<<15, 0);
    break;
    - case 0x10ec0215:
    case 0x10ec0225:
    + case 0x10ec0295:
    + case 0x10ec0299:
    + alc_update_coef_idx(codec, 0x67, 0xf000, 0x3000);
    + /* fallthrough */
    + case 0x10ec0215:
    case 0x10ec0233:
    case 0x10ec0236:
    case 0x10ec0255:
    @@ -336,10 +340,8 @@ static void alc_fill_eapd_coef(struct hd
    case 0x10ec0286:
    case 0x10ec0288:
    case 0x10ec0285:
    - case 0x10ec0295:
    case 0x10ec0298:
    case 0x10ec0289:
    - case 0x10ec0299:
    alc_update_coef_idx(codec, 0x10, 1<<9, 0);
    break;
    case 0x10ec0275:

    \
     
     \ /
      Last update: 2018-01-01 16:05    [W:4.113 / U:0.144 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site