lkml.org 
[lkml]   [2018]   [Jan]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.14 090/146] net/mlx5e: Fix features check of IPv6 traffic
    Date
    4.14-stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Gal Pressman <galp@mellanox.com>


    [ Upstream commit 2989ad1ec03021ee6d2193c35414f1d970a243de ]

    The assumption that the next header field contains the transport
    protocol is wrong for IPv6 packets with extension headers.
    Instead, we should look the inner-most next header field in the buffer.
    This will fix TSO offload for tunnels over IPv6 with extension headers.

    Performance testing: 19.25x improvement, cool!
    Measuring bandwidth of 16 threads TCP traffic over IPv6 GRE tap.
    CPU: Intel(R) Xeon(R) CPU E5-2660 v2 @ 2.20GHz
    NIC: Mellanox Technologies MT28800 Family [ConnectX-5 Ex]
    TSO: Enabled
    Before: 4,926.24 Mbps
    Now : 94,827.91 Mbps

    Fixes: b3f63c3d5e2c ("net/mlx5e: Add netdev support for VXLAN tunneling")
    Signed-off-by: Gal Pressman <galp@mellanox.com>
    Signed-off-by: Saeed Mahameed <saeedm@mellanox.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    ---
    drivers/net/ethernet/mellanox/mlx5/core/en_main.c | 3 ++-
    1 file changed, 2 insertions(+), 1 deletion(-)

    --- a/drivers/net/ethernet/mellanox/mlx5/core/en_main.c
    +++ b/drivers/net/ethernet/mellanox/mlx5/core/en_main.c
    @@ -3554,6 +3554,7 @@ static netdev_features_t mlx5e_tunnel_fe
    struct sk_buff *skb,
    netdev_features_t features)
    {
    + unsigned int offset = 0;
    struct udphdr *udph;
    u8 proto;
    u16 port;
    @@ -3563,7 +3564,7 @@ static netdev_features_t mlx5e_tunnel_fe
    proto = ip_hdr(skb)->protocol;
    break;
    case htons(ETH_P_IPV6):
    - proto = ipv6_hdr(skb)->nexthdr;
    + proto = ipv6_find_hdr(skb, &offset, -1, NULL, NULL);
    break;
    default:
    goto out;

    \
     
     \ /
      Last update: 2018-01-01 15:59    [W:4.094 / U:0.432 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site