lkml.org 
[lkml]   [2017]   [Sep]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Date
    Subject[PATCH 3.16 185/233] cpufreq: conservative: Allow down_threshold to take values from 1 to 10
    3.16.48-rc1 review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Tomasz Wilczyński <twilczynski@naver.com>

    commit b8e11f7d2791bd9320be1c6e772a60b2aa093e45 upstream.

    Commit 27ed3cd2ebf4 (cpufreq: conservative: Fix the logic in frequency
    decrease checking) removed the 10 point substraction when comparing the
    load against down_threshold but did not remove the related limit for the
    down_threshold value. As a result, down_threshold lower than 11 is not
    allowed even though values from 1 to 10 do work correctly too. The
    comment ("cannot be lower than 11 otherwise freq will not fall") also
    does not apply after removing the substraction.

    For this reason, allow down_threshold to take any value from 1 to 99
    and fix the related comment.

    Fixes: 27ed3cd2ebf4 (cpufreq: conservative: Fix the logic in frequency decrease checking)
    Signed-off-by: Tomasz Wilczyński <twilczynski@naver.com>
    Acked-by: Viresh Kumar <viresh.kumar@linaro.org>
    Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
    [bwh: Backported to 3.16: adjust context]
    Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
    ---
    drivers/cpufreq/cpufreq_conservative.c | 4 ++--
    1 file changed, 2 insertions(+), 2 deletions(-)

    --- a/drivers/cpufreq/cpufreq_conservative.c
    +++ b/drivers/cpufreq/cpufreq_conservative.c
    @@ -204,8 +204,8 @@ static ssize_t store_down_threshold(stru
    int ret;
    ret = sscanf(buf, "%u", &input);

    - /* cannot be lower than 11 otherwise freq will not fall */
    - if (ret != 1 || input < 11 || input > 100 ||
    + /* cannot be lower than 1 otherwise freq will not fall */
    + if (ret != 1 || input < 1 || input > 100 ||
    input >= cs_tuners->up_threshold)
    return -EINVAL;

    \
     
     \ /
      Last update: 2017-09-10 01:26    [W:2.287 / U:4.412 seconds]
    ©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site