Messages in this thread Patch in this message | | | From | Ben Hutchings <> | Date | Sat, 09 Sep 2017 22:47:14 +0100 | Subject | [PATCH 3.16 078/233] usb: chipidea: debug: check before accessing ci_role |
| |
3.16.48-rc1 review patch. If anyone has any objections, please let me know.
------------------
From: Michael Thalmeier <michael.thalmeier@hale.at>
commit 0340ff83cd4475261e7474033a381bc125b45244 upstream.
ci_role BUGs when the role is >= CI_ROLE_END.
Signed-off-by: Michael Thalmeier <michael.thalmeier@hale.at> Signed-off-by: Peter Chen <peter.chen@nxp.com> Signed-off-by: Ben Hutchings <ben@decadent.org.uk> --- drivers/usb/chipidea/debug.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
--- a/drivers/usb/chipidea/debug.c +++ b/drivers/usb/chipidea/debug.c @@ -286,7 +286,8 @@ static int ci_role_show(struct seq_file { struct ci_hdrc *ci = s->private; - seq_printf(s, "%s\n", ci_role(ci)->name); + if (ci->role != CI_ROLE_END) + seq_printf(s, "%s\n", ci_role(ci)->name); return 0; }
| |