lkml.org 
[lkml]   [2017]   [Sep]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] HID: usbhid: get/put around clearing needs_remote_wakeup
From
Date
Am Freitag, den 08.09.2017, 10:43 -0700 schrieb Dmitry Torokhov:
> From: Benson Leung <bleung@chromium.org>
>
> usbhid->intf->needs_remote_wakeup is set when a device is opened, and is
> cleared when a device is closed.
>
> In usbhid_open, usb_autopm_get_interface is called before setting the
> needs_remote_wakeup flag, and usb_autopm_put_interface is called after
> hid_start_in. However, when the device is closed in usbhid_close, we
> simply reset the flag and the device stays awake even though it could be
> suspended.

Hi,

but if the device is asleep, we do not want to wake it just to reset
the flag. Please use the no resume varieties. They did not exist when this
code was written and that is the reason behind the current code.

As it is your patch does more harm than good.

Regards
Oliver

\
 
 \ /
  Last update: 2017-09-09 09:39    [W:0.047 / U:46.576 seconds]
©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site