Messages in this thread | | | Date | Sat, 9 Sep 2017 09:14:51 +0200 | From | Greg KH <> | Subject | Re: [PATCH] staging: unisys: visorbus: Declared char * array as static const |
| |
On Sat, Sep 09, 2017 at 12:30:42PM +0530, Harsha Sharma wrote: > State explicitly that individual entries in array will not change. > > Signed-off-by: Harsha Sharma <harshasharmaiitr@gmail.com> > --- > drivers/staging/unisys/visorbus/visorchipset.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/staging/unisys/visorbus/visorchipset.c b/drivers/staging/unisys/visorbus/visorchipset.c > index 6d4498f..6f2a010 100644 > --- a/drivers/staging/unisys/visorbus/visorchipset.c > +++ b/drivers/staging/unisys/visorbus/visorchipset.c > @@ -1162,7 +1162,7 @@ static ssize_t deviceenabled_store(struct device *dev, > struct controlvm_message_packet *cmd = &req->msg.cmd; > char env_cmd[40], env_id[40], env_state[40], env_bus[40], env_dev[40], > env_func[40]; > - char *envp[] = { > + static const char * const envp[] = {
Are you _sure_ about this? Why make it static? That seems a bit "odd", don't you think? You need a lot more changelog text to get everyone to agree that this is ok to do...
Also, you forgot to cc: the actual maintainers of this code...
thanks,
greg k-h
| |