lkml.org 
[lkml]   [2017]   [Sep]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
Subject[PATCH 2/2] [media] xc4000: Adjust two null pointer checks in xc4000_fwupload()
From
Date
From: Markus Elfring <elfring@users.sourceforge.net>
Date: Sat, 9 Sep 2017 20:55:14 +0200
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

The script “checkpatch.pl” pointed information out like the following.

Comparison to NULL could be written !…

Thus fix the affected source code places.

Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
---
drivers/media/tuners/xc4000.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/media/tuners/xc4000.c b/drivers/media/tuners/xc4000.c
index bbf386127fc4..bd53e44b3cc8 100644
--- a/drivers/media/tuners/xc4000.c
+++ b/drivers/media/tuners/xc4000.c
@@ -775,5 +775,5 @@ static int xc4000_fwupload(struct dvb_frontend *fe)
priv->firm_version >> 8, priv->firm_version & 0xff);

priv->firm = kcalloc(n_array, sizeof(*priv->firm), GFP_KERNEL);
- if (priv->firm == NULL) {
+ if (!priv->firm) {
rc = -ENOMEM;
@@ -821,5 +821,5 @@ static int xc4000_fwupload(struct dvb_frontend *fe)
}

priv->firm[n].ptr = kzalloc(size, GFP_KERNEL);
- if (priv->firm[n].ptr == NULL) {
+ if (!priv->firm[n].ptr) {
rc = -ENOMEM;
--
2.14.1
\
 
 \ /
  Last update: 2017-09-09 21:15    [W:0.039 / U:32.812 seconds]
©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site