lkml.org 
[lkml]   [2017]   [Sep]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 1/2] staging: typec: tcpm: Validate source and sink caps
On Fri, Sep 08, 2017 at 10:27:27AM -0700, Badhri Jagan Sridharan wrote:
> >> +
> >> + for (i = 1; i < nr_pdo; i++) {
> >> + if (pdo_type(pdo[i]) < pdo_type(pdo[i - 1])) {
> >> + tcpm_log_force(port,
> >> + " err:PDOs should be in the following order: Fixed; Battery; Variable. pdo index:%u"
> >> + , i);
> >> + return -EINVAL;
> >> + } else if (pdo_type(pdo[i]) == pdo_type(pdo[i - 1])) {
> >
> > The else statement isn't needed. Pull this in one indent level.
>
> Just to clarify, you are suggesting,
> "if (pdo_type(pdo[i]) == pdo_type(pdo[i - 1]))"
> instead of "else if (pdo_type(pdo[i]) == pdo_type(pdo[i - 1]))"
> right ?
>

Sorry. My bad. We can't pull it in an indent level.

Thanks for answering the rest of my questions as well. It's clear to
me now.

regards,
dan carpenter

\
 
 \ /
  Last update: 2017-09-08 23:57    [W:0.052 / U:2.372 seconds]
©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site