lkml.org 
[lkml]   [2017]   [Sep]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
From
Subject[PATCH] pps-gpio: use IRQ edge config when not capturing both edges
Date
PPS signals with very short pulse-widths can be missed if their state
changes by the time the interrupt handler reads the GPIO pin state.

To avoid this in the case where we are only looking for one edge we can
use the edge configuration for the pin state but fall back to reading the
pin if both edges are being watched.

Signed-off-by: Tim Harvey <tharvey@gateworks.com>
---
drivers/pps/clients/pps-gpio.c | 11 ++++++++++-
1 file changed, 10 insertions(+), 1 deletion(-)

diff --git a/drivers/pps/clients/pps-gpio.c b/drivers/pps/clients/pps-gpio.c
index 333ad7d..0d2b807 100644
--- a/drivers/pps/clients/pps-gpio.c
+++ b/drivers/pps/clients/pps-gpio.c
@@ -61,7 +61,16 @@ static irqreturn_t pps_gpio_irq_handler(int irq, void *data)

info = data;

- rising_edge = gpio_get_value(info->gpio_pin);
+ /*
+ * if not capturing both assert/clear events use the IRQ state
+ * otherwise read the gpio state from the pin (which could miss
+ * assertions on very small pulse-widths due to interrupt latency
+ * and CPU performance).
+ */
+ if (!info->capture_clear)
+ rising_edge = !info->assert_falling_edge;
+ else
+ rising_edge = gpio_get_value(info->gpio_pin);
if ((rising_edge && !info->assert_falling_edge) ||
(!rising_edge && info->assert_falling_edge))
pps_event(info->pps, &ts, PPS_CAPTUREASSERT, NULL);
--
2.7.4
\
 
 \ /
  Last update: 2017-09-08 21:51    [W:0.070 / U:1.304 seconds]
©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site