lkml.org 
[lkml]   [2017]   [Sep]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH v2 34/40] tracing: Add 'last error' error facility for hist triggers
From
Date
On Fri, 2017-09-08 at 15:25 -0400, Steven Rostedt wrote:
> On Tue, 5 Sep 2017 16:57:46 -0500
> Tom Zanussi <tom.zanussi@linux.intel.com> wrote:
>
> > +static char *hist_err_str;
> > +static char *last_hist_cmd;
> > +
> > +static int hist_err_alloc(void)
> > +{
> > + int ret = 0;
> > +
> > + last_hist_cmd = kzalloc(MAX_FILTER_STR_VAL, GFP_KERNEL);
> > + if (!last_hist_cmd)
> > + return -ENOMEM;
> > +
> > + hist_err_str = kzalloc(MAX_FILTER_STR_VAL, GFP_KERNEL);
> > + if (!hist_err_str) {
> > + kfree(last_hist_cmd);
> > + ret = -ENOMEM;
> > + }
>
> This gets allocated during boot up. Why have it be allocated in the
> first place? Just have it be strings:
>
> static char hist_err_str[MAX_FILTER_STR_VAL];
> static char last_hist_cmd[MAX_FILTER_STR_VAL];
>
> You are not saving any space by doing it this way. In fact, you waste
> it because now you need to add the pointers to the strings.
>

Good point. I'll change that along with the other suggestions below.

Thanks,

Tom


\
 
 \ /
  Last update: 2017-09-08 21:46    [W:0.127 / U:15.292 seconds]
©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site