lkml.org 
[lkml]   [2017]   [Sep]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH] Staging: iio: adc: Added Space around binary op.
From


On 8 September 2017 05:47:52 BST, Himanshi Jain <himshijain.hj@gmail.com> wrote:
>Added space around(one on each side of) binary
>operator(-) as preferred according to kernel
>coding style.
>
>Signed-off-by: Himanshi Jain <himshijain.hj@gmail.com>

Take a closer look at that macro. It isn't doing what you think... To give a hint, changing this breaks userspace.

Jonathan


>---
> drivers/staging/iio/adc/ad7192.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/drivers/staging/iio/adc/ad7192.c
>b/drivers/staging/iio/adc/ad7192.c
>index d11c6de..1aee662 100644
>--- a/drivers/staging/iio/adc/ad7192.c
>+++ b/drivers/staging/iio/adc/ad7192.c
>@@ -341,7 +341,7 @@ static int ad7192_setup(struct ad7192_state *st,
> }
>
> static IIO_DEVICE_ATTR_NAMED(in_v_m_v_scale_available,
>- in_voltage-voltage_scale_available,
>+ in_voltage - voltage_scale_available,
> 0444, ad7192_show_scale_available, NULL, 0);
>
> static IIO_DEVICE_ATTR(in_voltage_scale_available, 0444,

--
Sent from my Android device with K-9 Mail. Please excuse my brevity.

\
 
 \ /
  Last update: 2017-09-08 08:29    [W:0.088 / U:0.176 seconds]
©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site