lkml.org 
[lkml]   [2017]   [Sep]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH V2] thermal/drivers/step_wise: Fix temperature regulation misbehavior
From
Date
On 08/09/2017 14:25, Keerthy wrote:
>
[ ... ]

> This definitely is an issue i have seen on dra7 and if step_wise by
> design can accommodate this change, It will fix the issue!

Ah, ok. I understood you thought we should not do the change and use the
DT crit trip instead.

> Then you should be updating the documentation as well.
>
> /*
> * If the temperature is higher than a trip point,
> * a. if the trend is THERMAL_TREND_RAISING, use higher cooling
> * state for this trip point
> * b. if the trend is THERMAL_TREND_DROPPING, use lower cooling
> * state for this trip point
>
> Now with your patch applied the point b. will change to:
>
> b. if the trend is THERMAL_TREND_DROPPING, Maintain the same cooling
> level till the temperature drops below trip point.

Ok, I will change accordingly.

Thanks.

-- Daniel


--
<http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs

Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog

\
 
 \ /
  Last update: 2017-09-08 15:59    [W:0.052 / U:0.256 seconds]
©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site