lkml.org 
[lkml]   [2017]   [Sep]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [Outreachy kernel] [PATCH v4] staging: pi433: Fixes minor typo errors
On Fri, Sep 08, 2017 at 11:45:20AM +0200, Julia Lawall wrote:
>
>
> On Fri, 8 Sep 2017, harsha wrote:
>
> > From: Harsha Sharma <harshasharmaiitr@gmail.com>
> >
> > Fixes checkpatch warning -- "occured" and "succesfully" are misspelled
> >
> > Signed-off-by: Harsha Sharma <harshasharmaiitr@gmail.com>
> > ---
> > Changes in v4:
> > -Correct the format of the subject.
> > -Signed-off properly.
>
> It's not signed off properly. Like Greg just said (maybe the mails
> crossed), the sign off needs to be the same as the From line. This
> probably relates to your git configuration or your mailer. Send the patch
> to yourself before sending it out on the mailing list to be sure that
> everything is ok.
>

This is actually OK-ish... It's better when we don't have the extra
From: and there is no need for that with gmail, but we sometimes allow
it for companies which have broken mailservers.

regards,
dan carpenter

\
 
 \ /
  Last update: 2017-09-08 11:51    [W:0.041 / U:0.748 seconds]
©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site