lkml.org 
[lkml]   [2017]   [Sep]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [Outreachy kernel] [PATCH v4] staging: pi433: Fixes minor typo errors


On Fri, 8 Sep 2017, harsha wrote:

> From: Harsha Sharma <harshasharmaiitr@gmail.com>
>
> Fixes checkpatch warning -- "occured" and "succesfully" are misspelled
>
> Signed-off-by: Harsha Sharma <harshasharmaiitr@gmail.com>
> ---
> Changes in v4:
> -Correct the format of the subject.
> -Signed-off properly.

It's not signed off properly. Like Greg just said (maybe the mails
crossed), the sign off needs to be the same as the From line. This
probably relates to your git configuration or your mailer. Send the patch
to yourself before sending it out on the mailing list to be sure that
everything is ok.

julia

> drivers/staging/pi433/pi433_if.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/staging/pi433/pi433_if.c b/drivers/staging/pi433/pi433_if.c
> index 6b9b7df..6a10478 100644
> --- a/drivers/staging/pi433/pi433_if.c
> +++ b/drivers/staging/pi433/pi433_if.c
> @@ -473,7 +473,7 @@ struct pi433_instance {
> }
>
>
> - /* rx done, wait was interrupted or error occured */
> + /* rx done, wait was interrupted or error occurred */
> abort:
> dev->interrupt_rx_allowed = true;
> SET_CHECKED(rf69_set_mode(dev->spi, standby));
> @@ -1033,7 +1033,7 @@ static int setup_GPIOs(struct pi433_device *device)
> if (retval)
> return retval;
>
> - dev_dbg(&device->spi->dev, "%s succesfully configured", name);
> + dev_dbg(&device->spi->dev, "%s successfully configured", name);
> }
>
> return 0;
> --
> 1.9.1
>
> --
> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> To post to this group, send email to outreachy-kernel@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/1504863598-16301-1-git-send-email-harshasharmaiitr%40gmail.com.
> For more options, visit https://groups.google.com/d/optout.
>

\
 
 \ /
  Last update: 2017-09-08 11:46    [W:0.088 / U:34.292 seconds]
©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site