Messages in this thread | | | Date | Fri, 8 Sep 2017 11:26:14 +0200 | From | Pavel Machek <> | Subject | Re: [PATCH RFC 5/5] Add KSZ8795 SPI driver |
| |
Hi!
> +static int ksz_spi_read(struct ksz_device *dev, u32 reg, u8 *data, > + unsigned int len) > +{ > + struct spi_device *spi = dev->priv; > + > + return ksz_spi_read_reg(spi, reg, data, len); } > + > +static int ksz_spi_read8(struct ksz_device *dev, u32 reg, u8 *val) { > + return ksz_spi_read(dev, reg, val, 1); } > + > +static int ksz_spi_read16(struct ksz_device *dev, u32 reg, u16 *val) { > + int ret = ksz_spi_read(dev, reg, (u8 *)val, 2); > + > + if (!ret) > + *val = be16_to_cpu(*val); > + > + return ret; > +}
> +static int ksz_spi_read32(struct ksz_device *dev, u32 reg, u32 *val) { > + int ret = ksz_spi_read(dev, reg, (u8 *)val, 4); > + > + if (!ret) > + *val = be32_to_cpu(*val); > + > + return ret; > +}
Please format according to CodingStyle. (Not only this.)
And this will be common for more drivers. Can it go to a header file and be included...?
Pavel -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html [unhandled content-type:application/pgp-signature] | |