lkml.org 
[lkml]   [2017]   [Sep]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH v2] pci: dwc: dra7xx: Add shutdown handler to cleanly turn off clocks
From
Date


On Wednesday 06 September 2017 07:26 PM, Keerthy wrote:
> Add shutdown handler to cleanly turn off clocks.
>
> Signed-off-by: Keerthy <j-keerthy@ti.com>
> Acked-by: Kishon Vijay Abraham I <kishon@ti.com>
> ---
>
> Changes in v2:
>
> * used a local dev pointer instead of dereferencing dev at multiple places.
> * dra7xx_pcie_stop_link before disabling clks in the shutdown path.
>
> drivers/pci/dwc/pci-dra7xx.c | 17 +++++++++++++++++
> 1 file changed, 17 insertions(+)
>
> diff --git a/drivers/pci/dwc/pci-dra7xx.c b/drivers/pci/dwc/pci-dra7xx.c
> index 0f9adf2..0d8307a 100644
> --- a/drivers/pci/dwc/pci-dra7xx.c
> +++ b/drivers/pci/dwc/pci-dra7xx.c
> @@ -779,6 +779,22 @@ static int dra7xx_pcie_suspend_noirq(struct device *dev)
> return 0;
> }
>
> +void dra7xx_pcie_shutdown(struct platform_device *pdev)

This is currently under #ifdef CONFIG_PM_SLEEP. I need to push this
function out of that. So i will post a v3.

> +{
> + struct device *dev = &pdev->dev;
> + struct dra7xx_pcie *dra7xx = dev_get_drvdata(dev);
> + int ret;
> +
> + dra7xx_pcie_stop_link(dra7xx->pci);
> +
> + ret = pm_runtime_put_sync(dev);
> + if (ret < 0)
> + dev_dbg(dev, "pm_runtime_put_sync failed\n");
> +
> + pm_runtime_disable(dev);
> + dra7xx_pcie_disable_phy(dra7xx);
> +}
> +
> static int dra7xx_pcie_resume_noirq(struct device *dev)
> {
> struct dra7xx_pcie *dra7xx = dev_get_drvdata(dev);
> @@ -807,5 +823,6 @@ static int dra7xx_pcie_resume_noirq(struct device *dev)
> .suppress_bind_attrs = true,
> .pm = &dra7xx_pcie_pm_ops,
> },
> + .shutdown = dra7xx_pcie_shutdown,
> };
> builtin_platform_driver_probe(dra7xx_pcie_driver, dra7xx_pcie_probe);
>

\
 
 \ /
  Last update: 2017-09-08 07:06    [W:0.032 / U:14.276 seconds]
©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site