lkml.org 
[lkml]   [2017]   [Sep]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [GIT PULL] Security subsystem updates for 4.14
On Thu, 7 Sep 2017, Linus Torvalds wrote:

> On Mon, Sep 4, 2017 at 3:29 AM, James Morris <jmorris@namei.org> wrote:
> >
> > IMA:
> > - A new integrity_read file operation method, avoids races when
> > calculating file hashes
>
> Honestly, this seems really odd.
>
> It documents that it needs to be called with i_rwsem held exclusively,
> and even has a lockdep assert to that effect (well, not really: the
> code claims "exclusive", but the lockdep assert does not), but I'm not
> actually seeing anybody doing it.
>
> Quite the reverse, I just see integrity_read_file() doing filp_open()
> on the pathname and passing it to integrity_kernel_read() with no
> locking.
>
> It really looks like just pure garbage to me. I pulled, and I'm not
> unpulling the whole thing. I don't think it's been tested, and I don't
> think it can be right.
>
> Tell me why I'm wrong, or tell me why that garbage made it in in the
> first place?

Mimi and Christoph worked together on this over several iterations -- I'll
let them respond.


--
James Morris
<jmorris@namei.org>

\
 
 \ /
  Last update: 2017-09-08 06:50    [W:0.064 / U:0.044 seconds]
©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site