lkml.org 
[lkml]   [2017]   [Sep]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] input: surface3_spi: make const array header static, reduces object code size
On Wed, Sep 06, 2017 at 10:51:37AM +0100, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> Don't populate the const array header on the stack, instead make it
> static. Makes the object code smaller by over 180 bytes:
>
> Before:
> text data bss dec hex filename
> 6003 1536 0 7539 1d73 surface3_spi.o
>
> After:
> text data bss dec hex filename
> 5726 1632 0 7358 1cbe surface3_spi.o
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---

Applied, thank you.

> drivers/input/touchscreen/surface3_spi.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/input/touchscreen/surface3_spi.c b/drivers/input/touchscreen/surface3_spi.c
> index e12fb9b63f31..ecba847889b5 100644
> --- a/drivers/input/touchscreen/surface3_spi.c
> +++ b/drivers/input/touchscreen/surface3_spi.c
> @@ -173,7 +173,7 @@ static void surface3_spi_process_pen(struct surface3_ts_data *ts_data, u8 *data)
>
> static void surface3_spi_process(struct surface3_ts_data *ts_data)
> {
> - const char header[] = {
> + static const char header[] = {
> 0xff, 0xff, 0xff, 0xff, 0xa5, 0x5a, 0xe7, 0x7e, 0x01
> };
> u8 *data = ts_data->rd_buf;
> --
> 2.14.1
>

--
Dmitry

\
 
 \ /
  Last update: 2017-09-07 23:32    [W:0.033 / U:13.684 seconds]
©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site