lkml.org 
[lkml]   [2017]   [Sep]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH] mm/debug: Change BUG_ON() crashes to survivable WARN_ON() warnings
On Thu, Sep 7, 2017 at 12:01 AM, Ingo Molnar <mingo@kernel.org> wrote:
>
> On a related note, this bug could have been more debuggable I think.
> Could we _please_ change VM_BUG_ON() to WARN_ON() or such?

I think it should be WARN_ON_ONCE(), or at least rate-limited some way.

Because once you have one of the VM bugs, they tend to repeat.

(We had a discussion long ago about making the "ONCE" behavior
actually be "once in a blue moon", and just mean that you warn at most
once every five minutes or something like that. Because the "once"
behavior has also resulted in people missing bugs, because the machine
has been up a long time, and maybe you got a warning at boot time, but
then five days later something fails silently again).

Also, should you do a "dump_vma()" if you then don't give a call stack
because you already did it earlier? So the rate limiting would need to
cover that part too, methinks.

Linus

\
 
 \ /
  Last update: 2017-09-07 22:51    [W:0.066 / U:1.420 seconds]
©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site