lkml.org 
[lkml]   [2017]   [Sep]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v6 04/11] swiotlb: Map the buffer if it was unmapped by XPFO
> -	if (PageHighMem(pfn_to_page(pfn))) {
> + if (PageHighMem(page) || xpfo_page_is_unmapped(page)) {

Please don't sprinkle xpfo details over various bits of code.

Just add a helper with a descriptive name, e.g.

page_is_unmapped()

that also includes the highmem case, as that will easily document
what this check is doing.

\
 
 \ /
  Last update: 2017-09-07 20:11    [W:0.289 / U:2.032 seconds]
©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site