lkml.org 
[lkml]   [2017]   [Sep]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 1/3] ALSA: ymfpci: Use common error handling code in snd_card_ymfpci_probe()
On Thu, 07 Sep 2017 09:41:39 +0200,
SF Markus Elfring wrote:
>
> >> @@ -336,21 +331,24 @@ static int snd_card_ymfpci_probe(struct pci_dev *pci,
> >> legacy_ctrl &= ~YMFPCI_LEGACY_FMEN;
> >> pci_write_config_word(pci, PCIR_DSXG_LEGACY, legacy_ctrl);
> >> } else if ((err = snd_opl3_hwdep_new(opl3, 0, 1, NULL)) < 0) {
> >> - snd_card_free(card);
> > ^^^^^^^^^^^^^^^^^^^
> >> dev_err(card->dev, "cannot create opl3 hwdep\n");
> > ^^^^^^^^^
> >> - return err;
> >> + goto free_card;
> >
> > Heh. I was worried that some of these re-orderings would introduce bugs
> > but actually this one fixes a use after free.
>
> Thanks for your constructive feedback.
>
> Does it mean that a special tag should be added to a commit message?

No need for resend, I'll add some more notes at merging.


thanks,

Takashi

\
 
 \ /
  Last update: 2017-09-07 10:10    [W:0.043 / U:1.640 seconds]
©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site