lkml.org 
[lkml]   [2017]   [Sep]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 00/14] Fix wrong %pF and %pS printk format specifier usages
On (09/06/17 22:27), Helge Deller wrote:
> This patch series fixes the wrong usages of the %pF and %pS printk format
> specifiers throughout the kernel code.
>
> Both specifiers have the same result on most architectures. But on ia64, ppc64
> and parisc64 architectures the %pF specifier does an extra conversion because
> there function pointers are actually function descriptors.

hm...

can we fix it in lib/vsprintf.c instead?

a) the patch set has "there is no problem on platform A, but still
let's just change it"

which is probably fine. but

b) you tweak/fix the currently existing users, OK. but there, most
likely, will be new users that will require fixes in the future.

-ss

\
 
 \ /
  Last update: 2017-09-07 02:48    [W:0.182 / U:0.788 seconds]
©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site