lkml.org 
[lkml]   [2017]   [Sep]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH v3] Staging: ccree: ssi_cipher.c: Remove unused variable.
On Thu, Sep 7, 2017 at 3:02 AM, Dan Carpenter <dan.carpenter@oracle.com> wrote:
> Always compile your patches.
>
> CC [M] drivers/staging/ccree/ssi_cipher.o
> drivers/staging/ccree/ssi_cipher.c: In function ‘ssi_blkcipher_complete’:
> drivers/staging/ccree/ssi_cipher.c:700:6: warning: unused variable ‘inflight_counter’ [-Wunused-variable]
> u32 inflight_counter;
> ^~~~~~~~~~~~~~~~
>
> You need to delete the declaration as well.
>
> Don't be in a rush to resend patches. I normally write them then let
> them sit in my outbox overnight and send them in the morning. The extra
> delay helps me to calm down a bit and focus better. Even though I've
> sent thousands of patches, it sometimes still stresses me out. It's
> like you're disagreeing with the original author and the reviewers are
> disagreeing with you and everyone's trying to be nice about it but
> patches are fundamentally points of disagreement and that's stress.
>
> regards,
> dan carpenter
>
Thanks , I'll be more careful !

Regards,
Srishti

\
 
 \ /
  Last update: 2017-09-06 23:43    [W:0.072 / U:0.392 seconds]
©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site