lkml.org 
[lkml]   [2017]   [Sep]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v3] Staging: ccree: ssi_cipher.c: Remove unused variable.
Always compile your patches.

CC [M] drivers/staging/ccree/ssi_cipher.o
drivers/staging/ccree/ssi_cipher.c: In function ‘ssi_blkcipher_complete’:
drivers/staging/ccree/ssi_cipher.c:700:6: warning: unused variable ‘inflight_counter’ [-Wunused-variable]
u32 inflight_counter;
^~~~~~~~~~~~~~~~

You need to delete the declaration as well.

Don't be in a rush to resend patches. I normally write them then let
them sit in my outbox overnight and send them in the morning. The extra
delay helps me to calm down a bit and focus better. Even though I've
sent thousands of patches, it sometimes still stresses me out. It's
like you're disagreeing with the original author and the reviewers are
disagreeing with you and everyone's trying to be nice about it but
patches are fundamentally points of disagreement and that's stress.

regards,
dan carpenter

\
 
 \ /
  Last update: 2017-09-06 23:33    [W:0.637 / U:0.640 seconds]
©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site