lkml.org 
[lkml]   [2017]   [Sep]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH] [RESEND] IB/uverbs: fix gcc-7 type warning
On Wed, Sep 6, 2017 at 3:58 PM, Christoph Hellwig <hch@infradead.org> wrote:
> On Wed, Sep 06, 2017 at 03:45:31PM +0200, Arnd Bergmann wrote:
>> We get a harmless warning about the fact that we use the result of a
>> multiplication as a condition:
>
> Please just turn the thing into a function while you're at it.
> I'm not even sure it needs to be inline..

Ok, the patch gets quite big once I also modify INIT_UDATA the same way,
but it seems like a good cleanup anyway. INIT_UDATA (renamed to
ib_uverbs_init_udata()) should definitely remain inline, so I'm leaving
both that way.

Arnd

\
 
 \ /
  Last update: 2017-09-06 22:44    [W:3.018 / U:7.552 seconds]
©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site