lkml.org 
[lkml]   [2017]   [Sep]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH RESEND v3 0/2] tpm_tis_spi: Use DMA-safe memory
On Thu, Aug 31, 2017 at 06:58:17PM +0200, Alexander Steffen wrote:
> The documentation says that DMA-safe memory is required for SPI transfers.
> The I/O buffers passed in by the caller can be allocated anywhere,
> including on the stack, which is not DMA-safe. So the data needs to be
> copied to separate, DMA-safe buffers.
>
> We did not see any DMA-related issues on our test systems, even without
> DMA-safe buffers. But this might simply be due to the fact that the SPI
> transfer size is rather small, so our systems do not bother to set up DMA
> transfers. Other systems might do so.
>
> v2:
> - Updated commit message with more explanations.
>
> v3:
> - Split into two patches, one for making the buffers DMA-safe and another
> for using only a single buffer.
>
> Alexander Steffen (2):
> tpm_tis_spi: Use DMA-safe memory for SPI transfers
> tpm_tis_spi: Use a single buffer for SPI transfers
>
> drivers/char/tpm/tpm_tis_spi.c | 32 ++++++++++++++++++--------------
> 1 file changed, 18 insertions(+), 14 deletions(-)
>
> --
> 2.7.4
>

Applied to my bleeding edge master brach for more convenient testing.
Have not yet applied to my next branch.

/Jarkko

\
 
 \ /
  Last update: 2017-09-06 14:55    [W:0.073 / U:5.812 seconds]
©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site