lkml.org 
[lkml]   [2017]   [Sep]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH net-next] rxrpc: Make service connection lookup always check for retry
From
From: David Howells <dhowells@redhat.com>
Date: Mon, 04 Sep 2017 15:28:28 +0100

> When an RxRPC service packet comes in, the target connection is looked up
> by an rb-tree search under RCU and a read-locked seqlock; the seqlock retry
> check is, however, currently skipped if we got a match, but probably
> shouldn't be in case the connection we found gets replaced whilst we're
> doing a search.
>
> Make the lookup procedure always go through need_seqretry(), even if the
> lookup was successful. This makes sure we always pick up on a write-lock
> event.
>
> On the other hand, since we don't take a ref on the object, but rely on RCU
> to prevent its destruction after dropping the seqlock, I'm not sure this is
> necessary.
>
> Signed-off-by: David Howells <dhowells@redhat.com>

Applied, thanks David.

\
 
 \ /
  Last update: 2017-09-05 23:42    [W:0.036 / U:16.156 seconds]
©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site