lkml.org 
[lkml]   [2017]   [Sep]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v5] arm64: allwinner: h5: add support for NanoPi NEO Plus2
Hi Antony,

On Mon, Sep 04, 2017 at 04:26:19PM +0200, Antony Antony wrote:
> On Mon, Sep 04, 2017 at 10:27:32AM +0200, Maxime Ripard wrote:
> > On Fri, Sep 01, 2017 at 12:53:13PM +0200, Antony Antony wrote:
> > > > > +&emac {
> > > > > + pinctrl-names = "default";
> > > > > + pinctrl-0 = <&emac_rgmii_pins>;
> > > > > + phy-supply = <&reg_gmac_3v3>;
> > > > > + phy-handle = <&ext_rgmii_phy>;
> > > > > + phy-mode = "rgmii";
> > > > > + status = "okay";
> > > > > +};
> > > > > +
> > > > > +&mdio {
> > > > > + ext_rgmii_phy: ethernet-phy@7 {
> > > > > + compatible = "ethernet-phy-ieee802.3-c22";
> > > > > + reg = <7>;
> > > > > + };
> > > > > +};
> > > >
> > > > This will not compile.
> > >
> > > I don't understand you, because, v5 file compiled for me. Here is output
> > > from running system, just the relevant part. using dtc -I fs
> > > /proc/device-tree
> > >
> > > ext_rgmii_phy = "/soc/ethernet@1c30000/mdio/ethernet-phy@7";
> > >
> > > ethernet@1c30000 {
> > > mdio {
> > > ..
> > > ethernet-phy@7 {
> > > compatible = "ethernet-phy-ieee802.3-c22";
> > > phandle = <0x1c>;
> > > reg = <0x7>;
> > > linux,phandle = <0x1c>;
> > > };
> > > };
> > >
> > > Is this what you expect?
> >
> > The bindings have been reverted recently, so if you based your work on
> > a version between 4.13-rc1 and 4.13-rc6 it will work, but anything
> > more recent will not compile anymore.
>
> I deleted emc and related node.
> I see. I hope stmmac: sun8i come back soon. It works well well on this
> board, running 4.13-rc6

Yeah, I hope too. Unfortunately, the DT bindings were still under
discussion after it's been merged, so we couldn't guarantee their
stability in the future.

> > > > > +&usb_otg {
> > > > > + dr_mode = "host";
> > > > > + status = "okay";
> > > > > +};
> > > > > +
> > > > > +&usbphy {
> > > > > + /* USB Type-A ports' VBUS is always on */
> > > > > + usb0_id_det-gpios = <&pio 6 12 GPIO_ACTIVE_HIGH>; /* PG12 */
> > > >
> > > > If it has an ID-detect pin, then it's not a host-only USB OTG
> > > > controller. dr_mode should be set to otga
> > >
> > > good point. I don't see an ID-detect connected in the schematic. The
> > > previous generation had.
> > >
> > > I will leave
> > > &usb_otg {
> > > dr_mode = "host";
> > > status = "okay";
> > > };
> > >
> > > &usbphy {
> > > /* USB Type-A ports' VBUS is always on */
> > > status = "okay";
> > > };
> >
> > Looking at the schematics, it seems that the micro USB isn't even
> > wired to a bus but is only used to power the board. If so, you can
> > even remove the usb_otg node.
>
> Yes, the Micro USB data pins are not connected. However, it there is a
> second USB A port connected to the processor. If I remove &usb_otg node, in
> 4.13-rc6, the second port goes to disabled.

Ok, someone got creative :)

Thanks!
Maxime

--
Maxime Ripard, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
[unhandled content-type:application/pgp-signature]
\
 
 \ /
  Last update: 2017-09-05 13:05    [W:0.089 / U:0.056 seconds]
©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site