lkml.org 
[lkml]   [2017]   [Sep]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v2 1/3] mfd: Add support for Cherry Trail Dollar Cove TI PMIC
On Tue, 05 Sep 2017, Takashi Iwai wrote:

> On Tue, 05 Sep 2017 09:25:53 +0200,
> Lee Jones wrote:
> >
> > On Mon, 04 Sep 2017, Takashi Iwai wrote:
> >
> > > On Mon, 04 Sep 2017 15:37:32 +0200,
> > > Lee Jones wrote:
> > > >
> > > > > +static struct mfd_cell dc_ti_dev[] = {
> > > > > + {
> > > > > + .name = "dc_ti_pwrbtn",
> > > > > + .num_resources = ARRAY_SIZE(power_button_resources),
> > > > > + .resources = power_button_resources,
> > > > > + },
> > > > > + {
> > > >
> > > > Place these on the same line.
> > >
> > > Does this and ...
> > >
> > >
> > > > > + },
> > > > > + {
> > > > > + .name = "dc_ti_region",
> > > > > + },
> > > >
> > > > This should be a one line entry:
> > > >
> > > > { .name = "dc_ti_region" },
> > >
> > > .... this match together? The result would be like:
> > >
> > > static struct mfd_cell dc_ti_dev[] = {
> > > {
> > > .name = "dc_ti_pwrbtn",
> > > .num_resources = ARRAY_SIZE(power_button_resources),
> > > .resources = power_button_resources,
> > > }, {
> > > .name = "chtdc_ti_adc",
> > > .num_resources = ARRAY_SIZE(adc_resources),
> > > .....
> > > }, { .name = "chtdc_ti_region", },
> > > };
> > >
> > > which I find a bit inconsistent.
> >
> > No, it doesn't.
>
> Heh, I find such a mixture annoying, but it's a matter of taste.

Coding style is always a matter of taste. :)

> > The single lines need to be on their own.
>
> So did I already in the v5 patch submitted yesterday.

I saw it, thanks.

--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog

\
 
 \ /
  Last update: 2017-09-05 10:15    [W:0.073 / U:3.988 seconds]
©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site