Messages in this thread | | | Date | Tue, 5 Sep 2017 08:39:27 +0100 | From | Lee Jones <> | Subject | Re: [PATCH resend 2/2] mfd: intel_soc_pmic: Differentiate between Bay and Cherry Trail CRC variants |
| |
On Mon, 04 Sep 2017, Hans de Goede wrote:
> Both Bay and Cherry Trail devices may be used together with a Crystal Cove > PMIC. Each platform has its own variant of the PMIC, which both use the > same ACPI HID, but they are not 100% compatible. > > This commits makes the intel_soc_pmic_core code check the _HRV of the > ACPI-firmware-node and selects intel_soc_pmic_config_byt_crc resp. > intel_soc_pmic_config_cht_crc based on this. > > This fixes the Bay Trail specific ACPI OpRegion code causing problems > on Cherry Trail devices. Specifically this was causing the external > microsd slot on a Dell Venue 8 5855 (Cherry Trail version) to not work > and the eMMC to become unreliable and throw lots of errors. > > Fixes: 5165238460 ("mfd: intel_soc_pmic: Core driver") > Reported-and-tested-by: russianneuromancer <russianneuromancer@ya.ru> > Signed-off-by: Hans de Goede <hdegoede@redhat.com> > Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com> > Acked-for-MFD-by: Lee Jones <lee.jones@linaro.org> > --- > drivers/mfd/Kconfig | 4 ++-- > drivers/mfd/intel_soc_pmic_core.c | 34 ++++++++++++++++++++++++++++------ > 2 files changed, 30 insertions(+), 8 deletions(-)
Applied, thanks.
-- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog
| |