lkml.org 
[lkml]   [2017]   [Sep]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRE: [PATCH 3/3] lockdep: Remove unnecessary acquisitions wrt workqueue flush
> -----Original Message-----
> From: Peter Zijlstra [mailto:peterz@infradead.org]
> Sent: Tuesday, September 05, 2017 4:26 PM
> To: Byungchul Park
> Cc: tj@kernel.org; johannes.berg@intel.com; mingo@kernel.org;
> tglx@linutronix.de; oleg@redhat.com; david@fromorbit.com; linux-
> kernel@vger.kernel.org; kernel-team@lge.com
> Subject: Re: [PATCH 3/3] lockdep: Remove unnecessary acquisitions wrt
> workqueue flush
>
> On Tue, Sep 05, 2017 at 11:29:14AM +0900, Byungchul Park wrote:
>
> > Also, lock_map_acquire() in process_one_work() is too strong for that
> > purpose. lock_map_acquire_might() is enough. Replaced it.
>
> NAK!! traditional annotations are superior to cross-release. They are not
> timing dependent.

You seem to mis-understand this. This also make them timing independent.
I also agree that we need timing independent report in workqueue code.
That's actually why I propose this patch.

I just tried to do it in a right way.
\
 
 \ /
  Last update: 2017-09-05 09:37    [W:0.060 / U:5.564 seconds]
©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site