lkml.org 
[lkml]   [2017]   [Sep]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH v2] clk: mb86s7x: Drop non-building driver
From
Date
Hi Stephen,

Am 01.09.2017 um 22:32 schrieb Stephen Boyd:
> On 08/25, Andreas Färber wrote:
>> It fails to build once we introduce the ARCH_MB86S7X Kconfig symbol:
>>
>> drivers/clk/clk-mb86s7x.c:27:10: fatal error: soc/mb86s7x/scb_mhu.h: No such file or directory
>> #include <soc/mb86s7x/scb_mhu.h>
>> ^~~~~~~~~~~~~~~~~~~~~~~
>> compilation terminated.
>>
>> And when commenting out that line, we get:
>>
>> drivers/clk/clk-mb86s7x.c: In function 'crg_gate_control':
>> drivers/clk/clk-mb86s7x.c:72:8: error: implicit declaration of function 'mb86s7x_send_packet' [-Werror=implicit-function-declaration]
>> ret = mb86s7x_send_packet(CMD_PERI_CLOCK_GATE_SET_REQ,
>> ^~~~~~~~~~~~~~~~~~~
>> drivers/clk/clk-mb86s7x.c:72:28: error: 'CMD_PERI_CLOCK_GATE_SET_REQ' undeclared (first use in this function)
>> ret = mb86s7x_send_packet(CMD_PERI_CLOCK_GATE_SET_REQ,
>> ^~~~~~~~~~~~~~~~~~~~~~~~~~~
>> drivers/clk/clk-mb86s7x.c:72:28: note: each undeclared identifier is reported only once for each function it appears in
>> drivers/clk/clk-mb86s7x.c: In function 'crg_rate_control':
>> drivers/clk/clk-mb86s7x.c:116:10: error: 'CMD_PERI_CLOCK_RATE_SET_REQ' undeclared (first use in this function)
>> code = CMD_PERI_CLOCK_RATE_SET_REQ;
>> ^~~~~~~~~~~~~~~~~~~~~~~~~~~
>> drivers/clk/clk-mb86s7x.c:121:10: error: 'CMD_PERI_CLOCK_RATE_GET_REQ' undeclared (first use in this function); did you mean 'CMD_PERI_CLOCK_RATE_SET_REQ'?
>> code = CMD_PERI_CLOCK_RATE_GET_REQ;
>> ^~~~~~~~~~~~~~~~~~~~~~~~~~~
>> CMD_PERI_CLOCK_RATE_SET_REQ
>> drivers/clk/clk-mb86s7x.c: In function 'mhu_cluster_rate':
>> drivers/clk/clk-mb86s7x.c:276:10: error: 'CMD_CPU_CLOCK_RATE_GET_REQ' undeclared (first use in this function)
>> code = CMD_CPU_CLOCK_RATE_GET_REQ;
>> ^~~~~~~~~~~~~~~~~~~~~~~~~~
>> drivers/clk/clk-mb86s7x.c:278:10: error: 'CMD_CPU_CLOCK_RATE_SET_REQ' undeclared (first use in this function); did you mean 'CMD_CPU_CLOCK_RATE_GET_REQ'?
>> code = CMD_CPU_CLOCK_RATE_SET_REQ;
>> ^~~~~~~~~~~~~~~~~~~~~~~~~~
>> CMD_CPU_CLOCK_RATE_GET_REQ
>> cc1: some warnings being treated as errors
>> scripts/Makefile.build:302: recipe for target
>> 'drivers/clk/clk-mb86s7x.o' failed
>> make[2]: *** [drivers/clk/clk-mb86s7x.o] Error 1
>>
>> Remove the driver for now.
>>
>> Signed-off-by: Andreas Färber <afaerber@suse.de>
>> ---
>
> Applied to clk-next

Thanks. Is this 4.14 or 4.15 material at this point? In particular I
wonder which release I can proceed to introduce ARCH_MB86S7X in - I'm
assuming we need to wait for this one to get merged, so 4.15 or 4.16
respectively?

Regards,
Andreas

--
SUSE Linux GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Felix Imendörffer, Jane Smithard, Graham Norton
HRB 21284 (AG Nürnberg)

\
 
 \ /
  Last update: 2017-09-04 17:47    [W:0.043 / U:10.108 seconds]
©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site