[lkml]   [2017]   [Sep]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH v2] ALSA: hda: Fix forget to free resource in error handling code path in hda_codec_driver_probe
On Mon, 04 Sep 2017 17:17:09 +0200,
Wang YanQing wrote:
> When hda_codec_driver_probe meet error and return failure, we need
> to free resource with, or we will get resource leak.
> Signed-off-by: Wang YanQing <>
> ---
> Changes v1-v2:
> 1: Fix calling after module_put, reported by Takashi Iwai.
> Hi! Takashi Iwai
> Because the only one calling site of is in
> hda_codec_driver_remove, and if hda_codec_driver_probe return
> failure, we will no chance to call the hda_codec_driver_remove,
> so I think we don't need to care below case:
> "Or, for safety, we may put an internal flag to indicate that the codec
> free got already called, and check it at before calling
>, too."

Fair enough, applied now.

I found patch_ca0132.c still misses the free at the error path in its
probe function, so I'll fix it.



 \ /
  Last update: 2017-09-04 17:34    [W:0.022 / U:7.940 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site