Messages in this thread | | | Date | Mon, 4 Sep 2017 16:56:22 +0300 | From | Leon Romanovsky <> | Subject | Re: [PATCH][V2] RDMA/nes: do not leak uninitialized resp.reserved to userspace Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit |
| |
On Mon, Sep 04, 2017 at 02:37:05PM +0100, Colin King wrote: > From: Colin Ian King <colin.king@canonical.com> > > resp.reserved has not been initialized and so the copy_to_user (via > ib_copy_to_udata) is copying uninitialized data from the stack back > to user space which is a potential information leak. Fix this by > initializing all of resp to zero. > > V2: Initialize all of the struct rather than just resp.reserved as > suggested by Leon Romanovsky.
Small nitpick, it is better to put changelog under "---" marker, so it won't be visible in the git log.
Thanks Reviewed-by: Leon Romanovsky <leonro@mellanox.com> [unhandled content-type:application/pgp-signature] | |